Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for visionOS platform #215

Merged
merged 11 commits into from
Jul 2, 2024
Merged

feat: added support for visionOS platform #215

merged 11 commits into from
Jul 2, 2024

Conversation

desusai7
Copy link
Contributor

@desusai7 desusai7 commented Jun 19, 2024 •
edited
Loading

📋 Changes

feat: added support for visionOS platform

  • Added a visionOS framework target and unit tests target for the framework.
  • Added a visionOS sample app and linked it to the unit tests target.
  • Updated all the ruby gems including cocoapods to support visionOS platform.
  • Upgraded Xcode to version 15.2 and macos runner to 13-x-large to support visionOS and its simulators.
  • Dropped support for xcode 14, swift version 5.7, 5.8, and now the minimum required version of Xcode is 15 and Swift is 5.9. (This is done to support visonOS)
  • Dropped support for iOS 13 & tvOS 13 platforms as per our support policy to support only last 4 major versions of any platform including the current major version.
  • CI checks for visionOS will be tackled as part of PR ci: added ci checks for visionOS platform #217 later as there are some issues with visionOS simulator on CI pipeline.

✅ Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@desusai7 desusai7 self-assigned this Jun 19, 2024
@desusai7 desusai7 marked this pull request as ready for review July 1, 2024 09:37
@desusai7 desusai7 requested a review from a team as a code owner July 1, 2024 09:37
@desusai7 desusai7 marked this pull request as draft July 1, 2024 09:57
@desusai7 desusai7 marked this pull request as ready for review July 1, 2024 14:57
@desusai7 desusai7 enabled auto-merge July 1, 2024 14:57
Widcket
Widcket reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the list of platforms in Platforms.swift need updating? https://github.com/auth0/SimpleKeychain/blob/master/Package.swift#L6

@desusai7
Copy link
Contributor Author

desusai7 commented Jul 2, 2024

Do the list of platforms in Platforms.swift need updating? https://github.com/auth0/SimpleKeychain/blob/master/Package.swift#L6

Tracking this in separate PR raised just now here as we will have to bump up the minimum supported swift version to 5.9 and drop support for Xcode 14 as well. I am considering bumping up the deployment targets of all the platforms to get rid of the versions which were not supported by apple anymore.

@Widcket
Copy link
Contributor

Widcket commented Jul 2, 2024

Tracking this in separate PR raised just now #218 as we will have to bump up the minimum supported swift version to 5.9 and drop support for Xcode 14 as well. I am considering bumping up the deployment targets of all the platforms to get rid of the versions which were not supported by apple anymore.

I'd suggest doing that first, and then updating the list of platforms in Platforms.swift here (on this PR), as bumping up the minimum supported swift version to 5.9 (and dropping Xcode 14) is a prerequisite.

@desusai7
Copy link
Contributor Author

desusai7 commented Jul 2, 2024

Tracking this in separate PR raised just now #218 as we will have to bump up the minimum supported swift version to 5.9 and drop support for Xcode 14 as well. I am considering bumping up the deployment targets of all the platforms to get rid of the versions which were not supported by apple anymore.

I'd suggest doing that first, and then updating the list of platforms in Platforms.swift here (on this PR), as bumping up the minimum supported swift version to 5.9 (and dropping Xcode 14) is a prerequisite.

Done that, Can you please take a look again now ?

@desusai7 desusai7 requested a review from Widcket July 2, 2024 13:17
@desusai7 desusai7 merged commit 97828c2 into master Jul 2, 2024
13 checks passed
@desusai7 desusai7 deleted the feat/supportVisionOS branch July 2, 2024 15:14
@desusai7 desusai7 mentioned this pull request Jul 2, 2024
Merged
@desusai7 desusai7 mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees

@desusai7 desusai7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desusai7 @Widcket